Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid exporting absolute path #60

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Apr 30, 2020

Otherwise the install prefix is not relocatable.

Related to ros2/ros2#915.

@dirk-thomas dirk-thomas self-assigned this Apr 30, 2020
Copy link

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dirk-thomas dirk-thomas merged commit e31d66e into master Apr 30, 2020
@dirk-thomas dirk-thomas deleted the dirk-thomas/avoid-exporting-absolute-path branch April 30, 2020 21:03
@lopsided98
Copy link

While CMAKE_INSTALL_FULL_LIBDIR is guaranteed to be a absolute path, CMAKE_INSTALL_LIBDIR is not guaranteed to be a path relative to CMAKE_INSTALL_PREFIX, and may be an absolute path as well.

Something like this: https://github.com/jtojnar/cmake-snips#concatenating-paths-when-building-pkg-config-files is needed here (although obviously applied to the CMake config file rather than the pkg-config file). This would allow the package to be relocatable if CMAKE_INSTALL_LIBDIR is a relative path, but still work if it is absolute.

@lopsided98
Copy link

See #66 for a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants