add SensorBase class as base class for sensors #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@YoheiKakiuchi definitely interesting, you have already a schema proposal for the sensors that you list in this PR? |
|
We need to have a discussion for this. I propose we continue (for now) in ros/urdfdom#28 |
Closed
rhaschke
added a commit
to ubi-agni/urdfdom_headers
that referenced
this pull request
Mar 17, 2016
…orBase as base class for sensors
rhaschke
pushed a commit
to ubi-agni/urdfdom_headers
that referenced
this pull request
Sep 7, 2016
rhaschke
pushed a commit
to ubi-agni/urdfdom_headers
that referenced
this pull request
Sep 15, 2016
rhaschke
pushed a commit
to ubi-agni/urdfdom_headers
that referenced
this pull request
Sep 7, 2018
rhaschke
pushed a commit
to ubi-agni/urdfdom_headers
that referenced
this pull request
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to use sensor descriptions on urdf_model.
So, I added SensorBase class as base class for sensors including VisionSensor.
This patch is compatible with ros/urdfdom#28