Only look at parent when line and cursor indents match #989
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given steps: - task: PowerShell@2 | We should be completing properties for the object that `task` is a part of, not the list under `steps`. Previously, the parent algorithm would see that the current indentation == the configured indentation and incorrectly choose the parent list as the "real" closest node, despite the cursor clearly being more indented than the list. Now, we also verify that the indentation of the current node equals the cursor indentation before deciding to look at the parent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Given
We should be completing properties for the object that
taskis a part of, not the list understeps.Previously, the parent algorithm would see that the current indentation == the configured indentation and incorrectly choose the parent list as the "real" closest node, despite the cursor clearly being more indented than the list.
Now, we also verify that the indentation of the current node equals the cursor indentation before deciding to look at the parent.
What issues does this PR fix or reference?
N/A, I caught this when trying to catch azure-pipelines-language-server back up with yaml-language-server.
Is it tested? How?
Added a unit test and confirmed that all tests pass.