Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not schema error message #966

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

p-spacek
Copy link
Contributor

@p-spacek p-spacek commented May 7, 2024

What does this PR do?

adds the possibility to customize errorMessage for not schema
using the same approach schema.errorMessage || localize(... as elsewhere

so it's possible to write:

   {
      not: {
        properties: {
          prop1: {
            type: 'number',
          },
        },
        errorMessage: 'prop1 must not be a number',
      }
    }

Is it tested? How?

manually, the same approach is already used elsewhere

p-spacek added a commit to jigx-com/rh-yaml-language-server that referenced this pull request May 7, 2024
@coveralls
Copy link

coveralls commented May 7, 2024

Coverage Status

coverage: 84.148% (-0.03%) from 84.174%
when pulling 5eb042c on jigx-com:fix/not-schema-error-message
into f039273 on redhat-developer:main.

@msivasubramaniaan
Copy link
Contributor

@p-spacek please rebase the repo

@p-spacek p-spacek force-pushed the fix/not-schema-error-message branch 2 times, most recently from c336af9 to 776da85 Compare May 29, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants