Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to vscode-languageserver 9 #910

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update to vscode-languageserver 9 #910

wants to merge 2 commits into from

Conversation

remcohaszing
Copy link
Contributor

@remcohaszing remcohaszing commented Aug 7, 2023 •
edited
Loading

What does this PR do?

Update vscode-languageserver to version 9.

What issues does this PR fix or reference?

N/A

Is it tested? How?

npm test

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 7, 2023
View reviewed changes
test/utils/testsTypes.ts
@@ -27,6 +29,9 @@
applyEdit(paramOrEdit: ApplyWorkspaceEditParams | WorkspaceEdit): Promise<ApplyWorkspaceEditResponse> {
throw new Error('Method not implemented.');
}
fillServerCapabilities(capabilities: ServerCapabilities<any>): void {

Check warning

Code scanning / ESLint

Disallow unused variables Warning test

'capabilities' is defined but never used.
test/utils/testsTypes.ts
@@ -27,6 +29,9 @@
applyEdit(paramOrEdit: ApplyWorkspaceEditParams | WorkspaceEdit): Promise<ApplyWorkspaceEditResponse> {
throw new Error('Method not implemented.');
}
fillServerCapabilities(capabilities: ServerCapabilities<any>): void {

Check warning

Code scanning / ESLint

Disallow the `any` type Warning test

Unexpected any. Specify a different type.
test/utils/testsTypes.ts
@@ -37,23 +42,26 @@
getWorkspaceFolders(): Promise<WorkspaceFolder[]> {
throw new Error('Method not implemented.');
}
initialize(capabilities: ClientCapabilities): void {

Check warning

Code scanning / ESLint

Disallow unused variables Warning test

'capabilities' is defined but never used.
test/utils/testsTypes.ts
onDidChangeWorkspaceFolders: Event<WorkspaceFoldersChangeEvent>;
onDidCreateFiles(handler: NotificationHandler<CreateFilesParams>): void {
onDidCreateFiles(handler: NotificationHandler<CreateFilesParams>): Disposable {

Check warning

Code scanning / ESLint

Disallow unused variables Warning test

'handler' is defined but never used.
test/utils/testsTypes.ts
throw new Error('Method not implemented.');
}
onDidRenameFiles(handler: NotificationHandler<RenameFilesParams>): void {
onDidRenameFiles(handler: NotificationHandler<RenameFilesParams>): Disposable {

Check warning

Code scanning / ESLint

Disallow unused variables Warning test

'handler' is defined but never used.
test/utils/testsTypes.ts
throw new Error('Method not implemented.');
}
onDidDeleteFiles(handler: NotificationHandler<DeleteFilesParams>): void {
onDidDeleteFiles(handler: NotificationHandler<DeleteFilesParams>): Disposable {

Check warning

Code scanning / ESLint

Disallow unused variables Warning test

'handler' is defined but never used.
test/utils/testsTypes.ts
throw new Error('Method not implemented.');
}
onWillCreateFiles(handler: RequestHandler<CreateFilesParams, WorkspaceEdit, never>): void {
onWillCreateFiles(handler: RequestHandler<CreateFilesParams, WorkspaceEdit, never>): Disposable {

Check warning

Code scanning / ESLint

Disallow unused variables Warning test

'handler' is defined but never used.
test/utils/testsTypes.ts
throw new Error('Method not implemented.');
}
onWillRenameFiles(handler: RequestHandler<RenameFilesParams, WorkspaceEdit, never>): void {
onWillRenameFiles(handler: RequestHandler<RenameFilesParams, WorkspaceEdit, never>): Disposable {

Check warning

Code scanning / ESLint

Disallow unused variables Warning test

'handler' is defined but never used.
test/utils/testsTypes.ts
throw new Error('Method not implemented.');
}
onWillDeleteFiles(handler: RequestHandler<DeleteFilesParams, WorkspaceEdit, never>): void {
onWillDeleteFiles(handler: RequestHandler<DeleteFilesParams, WorkspaceEdit, never>): Disposable {

Check warning

Code scanning / ESLint

Disallow unused variables Warning test

'handler' is defined but never used.
remcohaszing
remcohaszing commented Aug 7, 2023
View reviewed changes
yarn.lock Outdated
integrity sha512-wnJA4BnEjOSyFMvjZdpiOwhSq9uDoK8e/kpRJDTaMYzwlkrhG1fwDIZI94CLsLzlCK5cIbMMtFlJlfR57Lavmg==
[email protected]:
version "8.1.0"
resolved "https://registry.yarnpkg.com/vscode-jsonrpc/-/vscode-jsonrpc-8.1.0.tgz#cb9989c65e219e18533cc38e767611272d274c94"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The registry change is because whoever generated the old lockfile entries, has misconfigured yarn. By default yarn uses https://registry.yarnpkg.com. To troubleshoot this issue, run yarn config list.

@remcohaszing remcohaszing changed the title Update to vscode-languageserver 8 Update to vscode-languageserver 9 Sep 25, 2023
@coveralls
Copy link

coveralls commented Sep 25, 2023 •
edited
Loading

Coverage Status

coverage: 84.174%. remained the same
when pulling 90146fe on remcohaszing:vscode-languageserver-8
into f039273 on redhat-developer:main.

@Yokozuna59
Copy link

Hi there, are there any updates on this? I'm currently using a different package that uses a newer vscode-languageserver version, and I want to be able to use both, but errors are thrown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msivasubramaniaan msivasubramaniaan Awaiting requested review from msivasubramaniaan msivasubramaniaan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remcohaszing @coveralls @Yokozuna59