Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More type hint cleanup #1894

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

lrljoe
Copy link
Sponsor Collaborator

@lrljoe lrljoe commented Aug 25, 2024

  • Clean up some typehinting errors
  • Specify the files to ignore PHPStan errors from

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.06%. Comparing base (0c8ec45) to head (cf89972).
Report is 116 commits behind head on development.

Files with missing lines Patch % Lines
...iews/Traits/Helpers/ViewComponentColumnHelpers.php 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #1894      +/-   ##
=================================================
+ Coverage          87.30%   88.06%   +0.75%     
- Complexity          1672     1743      +71     
=================================================
  Files                150      161      +11     
  Lines               3891     4046     +155     
=================================================
+ Hits                3397     3563     +166     
+ Misses               494      483      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

stale bot commented Sep 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant