mix needs to use --stdin-filename to support non-elixir files like .heex
#319
Conversation
LucianoLaratelli
force-pushed
the
patch-1
branch
from
60e47d9
to
7441fe1
Compare
…heex`
I was seeing errors formatting `.heex` files from `elixir-mode`:
```
$ apheleia-from-project-root .formatter.exs mix format -
mix format failed for stdin
** (SyntaxError) invalid syntax found on stdin.exs:1:1:
error: syntax error before: '<'
│
1 │ <html lang="en" class="[scrollbar-gutter:stable]">
│ ^
│
└─ stdin.exs:1:1
(elixir 1.17.2) lib/code.ex:999: Code.format_string!/2
(mix 1.17.2) lib/mix/tasks/format.ex:649: Mix.Tasks.Format.elixir_format/2
(mix 1.17.2) lib/mix/tasks/format.ex:668: Mix.Tasks.Format.format_file/2
(elixir 1.17.2) lib/task/supervised.ex:101: Task.Supervised.invoke_mfa/2
(elixir 1.17.2) lib/task/supervised.ex:36: Task.Supervised.reply/4
```
Looking through the help page for `mix format`, I saw:
> `--stdin-filename' - path to the file being formatted on stdin. This is useful if you are using plugins to support custom filetypes such as .heex. Without passing this flag, it is assumed that the code being passed via stdin is valid Elixir code. Defaults to "stdin.exs".
This makes that change.
LucianoLaratelli
force-pushed
the
patch-1
branch
from
7441fe1
to
847360d
Compare
LucianoLaratelli
changed the title
…heex.heex
|
Looks like CI is failing thusly, is this option not widely available yet?
|
|
Ah, sorry about that. It looks like the earliest version that had the option available was 1.14.0. The first release candidate for that version was cut in August 2022, so just a little more than two years ago. The current version is 1.17.3. |
|
The dilemma I have is that Apheleia doesn't really know which version of a tool it's executing. When I get some time, I will think on this. I think a framework can be introduced to allow defining how Apheleia will determine the installed version of a tool and cache the result, then use that to condition on what arguments it will pass. Maybe we can get away with something as simple as implementing it in a wrapper script like |
|
Check the implementation in #322 |
|
Ah, very nice. Thanks for doing that :) |
Hey, hope all is well.
I was seeing errors formatting
.heexfiles fromelixir-modein*apheleia-apheleia-from-project-root-log*:Looking through the help page for
mix format, I saw:This makes that change.