remove private apis #3002
Merged
remove private apis #3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes `CGSPrivate.h`, `CPSPrivate.h`, as well as
`QSCGSTransition.{h,m}` which only seemed to serve as adapters for them.
It additionally either removes entirely or comments out (to serve as a
quick and dirty reference for reimplementation) code that depended on
these files.
This will break the pretty animations.
See also: #3001
This reverts commit a5640c6.
Closed
|
LGTM. Goodbye QGCPrivate :'( |
|
@n8henrie - please merge if this is ready. Only thing I can think of is to do a check in all the plugins for calls to |
|
There is some residual GUI funkiness after this PR, and I've got a long way before I understand much of the GUI stuff, but I think it's worth merging anyway, as everything else from this point onward will require a ton of rebasing otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at removing private APIs entirely which have previously been used for
animations.
I believe there is a lot more relevant code that could be removed, but after
removing the culprit files this seems to be the minimum needed to get QS to
build and run.