Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add askForColumns method #43

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

dmandrade
Copy link

@dmandrade dmandrade commented Sep 14, 2022

Add an askForColumns() method to let the user build a report. This is especially useful when you have a lot of columns and want to let the user pick the ones they need and customize the display order and format for each one.

  • create a askForColumns functionality
  • move handleExport to Exportable trait to reduce code duplication
  • in ExportAction checks if the record property is present to pass to hydrate, so we can use the action individually on each record on table, useful to use in custom exports. Ex: A report with all orders from a customer.

image
image

@pxlrbt
Copy link
Owner

pxlrbt commented Sep 14, 2022

Thanks for your PR. I will check this after my holiday.

Copy link

@Pedrovictorrr Pedrovictorrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codigo valido

@vincent-tarrit
Copy link

Hello, Would it be possible to merge this PR in the main branch ? I found this feature super useful ! Thank you !

@pxlrbt
Copy link
Owner

pxlrbt commented Feb 2, 2024

@vincent-tarrit The PR was quite large and I started reviewing it some time ago. But I didn't find the time to do all the refactoring needed, yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants