This repository has been archived by the owner on Jul 5, 2021. It is now read-only.
Create 404 page #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidiego
suggested changes
Sep 16, 2020
There was a problem hiding this comment.
Thank you for your PR @HigorSegobia. I left some comments that need to be solved before get a merge! Let me know if you have any questions.
OBS: You need to add tests for another components too.
tests/components/PageError.spec.tsx
Outdated
| it('should render component properly', () => { | ||
| const wrap = shallow(<PageError code="foo" message="bar" description="test" />); | ||
|
|
||
| expect(wrap).toBeCalled; |
There was a problem hiding this comment.
Check the test from other components! You need to check if Page renders the components correctly!
guidiego
suggested changes
Sep 30, 2020
|
|
||
| describe('components/BackgroundParticles', () => { | ||
| it('should render component properly', () => { | ||
| const wrap = shallow(<BackgroundParticles />); |
There was a problem hiding this comment.
You not test it properly!
You should chec toContainsElement en see if it calls Particle with correct arguments.
tests/components/PageError.spec.tsx
Outdated
| it('should render component properly', () => { | ||
| const wrap = shallow(<PageError code="foo" message="bar" description="test" />); | ||
|
|
||
| expect(wrap).toBeCalled; |
guidiego
reviewed
Nov 14, 2020
| }, | ||
| }; | ||
|
|
||
| type Props = { classes: Record<string, string> }; |
There was a problem hiding this comment.
I discover how to fix it and avoid it!
import { WithStyles } from '@material-ui/core/styles';
interface Props extends WithStyles<typeof BackgroundParticlesStyles> {
// other props
}| import Particles, { IParticlesParams } from 'react-particles-js'; | ||
| import { withStyles } from '@material-ui/core/styles'; | ||
|
|
||
| const useStyles = withStyles((theme) => ({ |
There was a problem hiding this comment.
I will need that you change it to:
const BackgroundParticlesStyles = (theme: Theme) => createStyles({ ... });
const useStyles = withStyles(BackgroundParticlesStyles);
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request related to issue #422 Add 404 page
Some images of how the final result was both on the web and mobile.