Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showheroes bid adapter: full rework of the adapter #12283

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

FilipStamenkovic
Copy link
Contributor

Type of change

  • Updated bidder adapter

Description of change

Update the showheroes-bs bidder adapter.

PR has the following updates:

  • remove legacy code that is not supported anymore
  • replace the old endpoint with prebid-sh with the new openrtb2/auction
  • use ortbConverter to construct a bid request
  • in case of outstream ads, provide the renderer-related parameters in the response (the old static renderer is not working anymore)
  • by using openRTB, automatically add support for: fpd, floor module, eids, etc.

To test the upgrade just set the openRTB request as a test request:

pbjs.setConfig({ortb2: {test: 1}})

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants