Ozone Project Bid Adapter: Support for auctionId and transactionId when a publisher opts in #12267
Conversation
|
Your adapter is generally too complicated :) it can be dramatically simplified with modern tools I see you are taking the full ortb object now, which might make @justadreamer pr no longer needed |
| @@ -891,7 +894,9 @@ export const spec = { | |||
| params: bid.params, | |||
| price: bid.price, | |||
| transactionId: bid.transactionId, | |||
| ttl: bid.ttl | |||
| ttl: bid.ttl, | |||
| ortb2: deepAccess(bid, 'ortb2'), | |||
There was a problem hiding this comment.
You're going to end up with enormous redundancy within your payload
There was a problem hiding this comment.
this is purely for logging purposes as opposed to payload that is sent.
|
Holding merge for @AskRupert-DM responses, thanks |
updated device object values to come from ortb.device
|
have added the change to the device object per @justadreamer pr @patmmccann - Some of the complication that you mention is for logging/debugging purposes which is useful for our technical account management teams, and some of it is down to the way in which it’s grown over time, which in our next version I can certainly look at refactoring. |
|
Thanks! |
Type of change
Description of change
added support for auctionId and transactionId where a publisher has opted in for these values to be set.