Don't create unordered news and events folder by default

[rodfersou]

closes #552

[mister-roboto]

@rodfersou thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

[rodfersou]

@jenkins-plone-org please run jobs

[jensens]

May you give us more details on this change? Even when following the two issues I do not get the nature of the problem this may solve. Also:

• What does unordered mean in context of IOrdering?
• Why was it there and
• what is set by default now, after removing the lines?
• What is changing for the users?

[rodfersou]

• What does unordered mean in context of IOrdering?

with Unordered folder it is impossible to get the object order in a folder

• Why was it there and

good question.. don't know, but I'm assuming it is a mistake

• what is set by default now, after removing the lines?

if remove those lines will use the default ordering

• What is changing for the users?

no change for users, but for restapi it is possible to get the next and previous item at those folders.

[jensens]

Given tests go green, I feel fine.

[rodfersou]

@jenkins-plone-org please run jobs

[rodfersou]

well.. there are some tests preventing this change at Products.CMFPlone

will take a look at it if can find the reason to be unordered, or if can remove those tests

[rodfersou]

@jensens I'm looking the tests, this comment make me feel that should not touch members folders, but the others are okay to become unordered.

[rodfersou]

looks like Jenkins is not working now.. will try again other day 😄

[mauritsvanrees]

Can you edit the news snippet to explain that this is only about the standard news and events folders?
Currently it sounds like this is a change for all folders, so also folders that an editor creates manually, which would mean a major, potentially breaking change.

I guess I can understand why news and events were unordered: by default it makes no sense to manually order items here, because you simply view them through the Collection, which orders them with most recent news item first, or nearest future event first.
Should be okay to change this.

[rodfersou]

related to plone/Products.CMFPlone#3142

[jensens]

@jenkins-plone-org please run jobs