Skip to content

Commit

Permalink
Merge pull request #665 from plone/pa-discussion-core-addon
Browse files Browse the repository at this point in the history
do not enable plone.allowdiscussion by default
  • Loading branch information
mauritsvanrees authored Sep 2, 2024
2 parents 9451abf + f00aae7 commit ce8fd19
Show file tree
Hide file tree
Showing 11 changed files with 14 additions and 16 deletions.
3 changes: 3 additions & 0 deletions .meta.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ commit-id = "a89af8f2"
[pyproject]
codespell_ignores = "oder,ist,crate"
dependencies_ignores = "['ZServer', 'plone.app.event', 'Products.CMFPlone',]"

[tox]
constraints_file = "https://dist.plone.org/release/6.1-dev/constraints.txt"
3 changes: 3 additions & 0 deletions news/665.breaking
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Do not enable plone.allowdiscussion by default, it is a core add-on now.
This is for Plone 6.1, so is a breaking change.
[@jensens]
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
>
<element value="plone.namefromtitle" />
<element value="plone.collection" />
<element value="plone.allowdiscussion" />
<element value="plone.shortname" />
<element value="plone.excludefromnavigation" />
<element value="plone.dublincore" />
Expand Down
1 change: 0 additions & 1 deletion plone/app/contenttypes/profiles/default/types/Document.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
purge="false"
>
<element value="plone.namefromtitle" />
<element value="plone.allowdiscussion" />
<element value="plone.excludefromnavigation" />
<element value="plone.shortname" />
<element value="plone.dublincore" />
Expand Down
1 change: 0 additions & 1 deletion plone/app/contenttypes/profiles/default/types/File.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
<element value="plone.publication" />
<element value="plone.ownership" />
<element value="plone.namefromfilename" />
<element value="plone.allowdiscussion" />
<element value="plone.shortname" />
<element value="plone.excludefromnavigation" />
<element value="plone.relateditems" />
Expand Down
1 change: 0 additions & 1 deletion plone/app/contenttypes/profiles/default/types/Folder.xml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
>
<element value="plone.dublincore" />
<element value="plone.namefromtitle" />
<element value="plone.allowdiscussion" />
<element value="plone.excludefromnavigation" />
<element value="plone.shortname" />
<element value="plone.constraintypes" />
Expand Down
1 change: 0 additions & 1 deletion plone/app/contenttypes/profiles/default/types/Image.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
<element value="plone.categorization" />
<element value="plone.publication" />
<element value="plone.ownership" />
<element value="plone.allowdiscussion" />
<element value="plone.shortname" />
<element value="plone.namefromfilename" />
<element value="plone.excludefromnavigation" />
Expand Down
1 change: 0 additions & 1 deletion plone/app/contenttypes/profiles/default/types/Link.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
<property name="behaviors"
purge="false"
>
<element value="plone.allowdiscussion" />
<element value="plone.shortname" />
<element value="plone.dublincore" />
<element value="plone.namefromtitle" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
<element value="plone.dublincore" />
<element value="plone.richtext" />
<element value="plone.namefromtitle" />
<element value="plone.allowdiscussion" />
<element value="plone.shortname" />
<element value="plone.excludefromnavigation" />
<element value="plone.relateditems" />
Expand Down
9 changes: 4 additions & 5 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import os


version = "3.0.10.dev0"
version = "4.0.0.dev0"


def read(*rnames):
Expand All @@ -24,16 +24,15 @@ def read(*rnames):
"Development Status :: 5 - Production/Stable",
"Environment :: Web Environment",
"Framework :: Plone",
"Framework :: Plone :: 6.0",
"Framework :: Plone :: 6.1",
"Framework :: Plone :: Core",
"Framework :: Zope :: 5",
"License :: OSI Approved :: GNU General Public License v2 (GPLv2)",
"Operating System :: OS Independent",
"Programming Language :: Python",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
],
keywords="plone content types dexterity",
author="Plone Foundation",
Expand All @@ -44,7 +43,7 @@ def read(*rnames):
namespace_packages=["plone", "plone.app"],
include_package_data=True,
zip_safe=False,
python_requires=">=3.8",
python_requires=">=3.10",
install_requires=[
"setuptools",
"plone.app.contentmenu",
Expand Down
8 changes: 4 additions & 4 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ set_env =
##
deps =
zope.testrunner
-c https://dist.plone.org/release/6.0-dev/constraints.txt
-c https://dist.plone.org/release/6.1-dev/constraints.txt

##
# Specify additional deps in .meta.toml:
Expand Down Expand Up @@ -152,7 +152,7 @@ set_env =
deps =
coverage
zope.testrunner
-c https://dist.plone.org/release/6.0-dev/constraints.txt
-c https://dist.plone.org/release/6.1-dev/constraints.txt

commands =
rfbrowser init
Expand All @@ -171,7 +171,7 @@ deps =
twine
build
towncrier
-c https://dist.plone.org/release/6.0-dev/constraints.txt
-c https://dist.plone.org/release/6.1-dev/constraints.txt

commands =
# fake version to not have to install the package
Expand Down Expand Up @@ -202,7 +202,7 @@ allowlist_externals =
deps =
pipdeptree
pipforester
-c https://dist.plone.org/release/6.0-dev/constraints.txt
-c https://dist.plone.org/release/6.1-dev/constraints.txt

commands =
# Generate the full dependency tree
Expand Down

0 comments on commit ce8fd19

Please sign in to comment.