Release 3.0.0 #88
Merged
Release 3.0.0 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ptrollinspt
commented
May 10, 2024
ptrollinspt
commented
- TSD-320: Github issues
- TypeError: round(): Argument #1 ($num) must be of type int|float, string given in .../vendor/pixlee/magento2/Model/Cart.php:161 #84
- Fix round params
- refactor conversion analytics to handle all product types
- Adding try catch to loading product for configurable type fail #85
- refactor add to cart analytics to match conversion
- fixed conversion sku
- moved preparePayload to service
- TypeError: round(): Argument #1 ($num) must be of type int|float, string given in .../vendor/pixlee/magento2/Model/Cart.php:161 #84
- TSD-321: Use Private API Key (TSD-321: Use Private API Key #87)
- Add new config for Private API Key
- Update Distillery service to use Private API Key
- Obscure key
- Catch Notify exceptions
* TSD-320: Github issues 84 & 85; fix round params * TSD-320: Github issues 84 & 85; force float getQtyOrdered returns string * TSD-320: Github issues 85; refactor conversion analytics to handle all product types * TSD-321: Use Private API Key (#87) * TSD-320: Github issues 85; refactor add to cart analytics to match conversion; fixed conversion sku; moved preparePayload to service * TSD-321: Use Private API Key; Change analytics back to api_key; remove fallback * TSD-321: Use Private API Key; obscure key; Catch notify exceptions * TSD-321: Use Private API Key; bump version for API update
SungjunApp
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.