Handle clicks that occur inside an <a> tag

Fixes #1
phlex-ruby · Mar 5, 2024 · 7fcded7 · 7fcded7
1 parent 211c9dc
commit 7fcded7
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 44 deletions.
diff --git a/dist/phlex.js b/dist/phlex.js
diff --git a/src/phlex.ts b/src/phlex.ts
@@ -59,31 +59,34 @@ export function init(): void {
 	// });
 
 	document.addEventListener("click", (event) => {
-		const link = event.target;
-
-		if (link instanceof HTMLAnchorElement) {
-			if (event.metaKey || event.ctrlKey || event.shiftKey) return;
-
-			if (link.ariaDisabled) {
-				event.preventDefault();
-				return;
-			}
-
-			const href = link.href;
-			const action = link.dataset.action;
-			const targetId = link.dataset.target;
-			const fragment = link.dataset.fragment;
-
-			if (action) {
-				event.preventDefault();
-				link.ariaDisabled = "true";
-
-				createEvent(href, targetId, fragment).then((event) => {
-					const actionMethod = Actions.get(action);
-					if (actionMethod) actionMethod(event);
-
-					link.ariaDisabled = null;
-				});
+		const targetElement = event.target;
+		if (targetElement instanceof Element) {
+			const link = targetElement.closest("a");
+
+			if (link instanceof HTMLAnchorElement) {
+				if (event.metaKey || event.ctrlKey || event.shiftKey) return;
+
+				if (link.ariaDisabled) {
+					event.preventDefault();
+					return;
+				}
+
+				const href = link.href;
+				const action = link.dataset.action;
+				const targetId = link.dataset.target;
+				const fragment = link.dataset.fragment;
+
+				if (action) {
+					event.preventDefault();
+					link.ariaDisabled = "true";
+
+					createEvent(href, targetId, fragment).then((event) => {
+						const actionMethod = Actions.get(action);
+						if (actionMethod) actionMethod(event);
+
+						link.ariaDisabled = null;
+					});
+				}
 			}
 		}
 	});