Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vender: add vender and explicit set protoc-gen-grpc-gateway version #18

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

unship
Copy link

@unship unship commented Jul 4, 2017

fix #16

README.md Outdated
$ git clone https://github.com/philips/grpc-gateway-example.git
$ glide install
$ go install ./vender/github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway
$ go install ./vender/github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@unship unship force-pushed the fix-grpc-gateway-version-patch branch from 3c0d6e5 to 872b49a Compare July 6, 2017 01:12
@knweiss
Copy link

knweiss commented Sep 10, 2017

Two minor comments:

  • Since go1.7 golang.org/x/net/context is part of the Go runtime as context . IMHO the imports should be changed. Then the context package could be removed from vendoring.
  • There are still several "vender" typos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build fail
3 participants