Skip to content

Commit

Permalink
Blacklist the 1.8.11-ms-store-11 tag
Browse files Browse the repository at this point in the history
This version is not available for download.

Fixes #30
  • Loading branch information
per1234 committed Feb 7, 2020
1 parent bcd65a3 commit 9c5a7aa
Showing 1 changed file with 16 additions and 3 deletions.
19 changes: 16 additions & 3 deletions arduino-ci-script.sh
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ function install_ide() {
return_handler "$ARDUINO_CI_SCRIPT_FAILURE_EXIT_STATUS"
fi

# Generate an array declaration string containing a list all Arduino IDE versions which support CLI (1.5.2+ according to https://github.com/arduino/Arduino/blob/master/build/shared/manpage.adoc#history)
# Generate an array declaration string containing a list all available Arduino IDE versions which support CLI
# Save the current folder
local -r previousFolder="$PWD"
cd "$ARDUINO_CI_SCRIPT_TEMPORARY_FOLDER"
Expand All @@ -204,13 +204,26 @@ function install_ide() {
cd Arduino
git remote add origin https://github.com/arduino/Arduino.git
if [[ "$startIDEversion" != "1.6.2" ]] && [[ "$startIDEversion" != "1.6.2" ]]; then
# Arduino IDE 1.6.2 has the nasty behavior of moving the included hardware cores to the .arduino15 folder, causing those versions to be used for all builds after Arduino IDE 1.6.2 is used. For that reason, 1.6.2 will only be installed if explicitly specified in the install_ide version arguments
# See "Arduino IDE version blacklist" documentation below
local -r IDEversion162regex=--regex='refs/tags/1\.6\.2'
if [[ "$ARDUINO_CI_SCRIPT_VERBOSITY_LEVEL" -gt 0 ]]; then
echo "NOTE: Due to not playing nicely with other versions, Arduino IDE 1.6.2 will not be installed unless explicitly specified in the version arguments."
fi
fi
local -r ARDUINO_CI_SCRIPT_FULL_IDE_VERSION_LIST_ARRAY="${ARDUINO_CI_SCRIPT_IDE_VERSION_LIST_ARRAY_DECLARATION}'(\"$(git ls-remote --quiet --tags --refs | grep --invert-match --regexp='refs/tags/1\.0' --regexp='refs/tags/1\.5$' --regexp='refs/tags/1\.5\.1$' --regexp='refs/tags/1\.5\.4-r2$' --regexp='refs/tags/1\.5\.5-r2$' --regexp='refs/tags/1\.5\.7-macosx-java7$' --regexp='refs/tags/1\.5\.8-macosx-java7$' ${IDEversion162regex} --regexp='refs/tags/1\.6\.5-r2$' --regexp='refs/tags/1\.6\.5-r3$' | grep --regexp='refs/tags/[0-9]\+\.[0-9]\+\.[0-9]\+\(\(-.*$\)\|$\)' | cut --delimiter='/' --fields=3 | sort --version-sort | sed ':a;N;$!ba;s/\n/\" \"/g')\")'"

# Arduino IDE tag blacklist:
# <1.5.2: no CLI (https://github.com/arduino/Arduino/blob/master/build/shared/manpage.adoc#history)
# 1.5.4-r2: Not available for download
# 1.5.5-r2: Not available for download
# 1.5.7-macosx-java7: Not available for download
# 1.5.8-macosx-java7: Not available for download
# 1.6.2: has the nasty behavior of moving the included hardware cores to the .arduino15 folder, causing those versions to be used for all builds after Arduino IDE 1.6.2 is used. For that reason, 1.6.2 will only be installed if explicitly specified in the install_ide version arguments
# 1.6.5-r2: Not available for download
# 1.6.5-r3: Not available for download
# 1.6.5-r2: Not available for download
# 1.6.5-r3: Not available for download
# 1.8.11-ms-store-1: Not available for download
local -r ARDUINO_CI_SCRIPT_FULL_IDE_VERSION_LIST_ARRAY="${ARDUINO_CI_SCRIPT_IDE_VERSION_LIST_ARRAY_DECLARATION}'(\"$(git ls-remote --quiet --tags --refs | grep --invert-match --regexp='refs/tags/1\.0' --regexp='refs/tags/1\.5$' --regexp='refs/tags/1\.5\.1$' --regexp='refs/tags/1\.5\.4-r2$' --regexp='refs/tags/1\.5\.5-r2$' --regexp='refs/tags/1\.5\.7-macosx-java7$' --regexp='refs/tags/1\.5\.8-macosx-java7$' ${IDEversion162regex} --regexp='refs/tags/1\.6\.5-r2$' --regexp='refs/tags/1\.6\.5-r3$' --regexp='refs/tags/1\.8\.11-ms-store-1$' | grep --regexp='refs/tags/[0-9]\+\.[0-9]\+\.[0-9]\+\(\(-.*$\)\|$\)' | cut --delimiter='/' --fields=3 | sort --version-sort | sed ':a;N;$!ba;s/\n/\" \"/g')\")'"
cd ..
# Remove the temporary repo
rm Arduino --recursive --force
Expand Down

6 comments on commit 9c5a7aa

@arduino-ci-script-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arduino-ci-script-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once completed, the job reports for Travis CI build 937 will be found at:
https://github.com/per1234/CI-reports/tree/arduino-ci-script/build_00937

@arduino-ci-script-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arduino-ci-script-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once completed, the job reports for Travis CI build 938 will be found at:
https://github.com/per1234/CI-reports/tree/arduino-ci-script/build_00938

@arduino-ci-script-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arduino-ci-script-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once completed, the job reports for Travis CI build 939 will be found at:
https://github.com/per1234/CI-reports/tree/arduino-ci-script/build_00939

Please sign in to comment.