Skip to content

Commit

Permalink
Make the duplicate IDE version code not mess up sort order
Browse files Browse the repository at this point in the history
The list was originally sorted correctly by version but it appears the sort --unique command changes the sort order back to alphabetical.
  • Loading branch information
per1234 committed Feb 25, 2018
1 parent f30d214 commit 0ca2852
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arduino-ci-script.sh
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ function generate_ide_version_list_array()

# Remove duplicates from list https://stackoverflow.com/a/13648438
# shellcheck disable=SC2207
readonly local uniqueIDElistArray=($(echo "${rawIDElistArray[@]}" | tr ' ' '\n' | sort -u | tr '\n' ' '))
readonly local uniqueIDElistArray=($(echo "${rawIDElistArray[@]}" | tr ' ' '\n' | sort --unique --version-sort | tr '\n' ' '))

# Generate ARDUINO_CI_SCRIPT_GENERATED_IDE_VERSION_LIST_ARRAY
ARDUINO_CI_SCRIPT_GENERATED_IDE_VERSION_LIST_ARRAY="$ARDUINO_CI_SCRIPT_IDE_VERSION_LIST_ARRAY_DECLARATION"'('
Expand Down

4 comments on commit 0ca2852

@arduino-ci-script-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arduino-ci-script-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once completed, the job reports for Travis CI build 641 will be found at:
https://github.com/per1234/CI-reports/tree/arduino-ci-script/build_00641

@arduino-ci-script-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arduino-ci-script-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once completed, the job reports for Travis CI build 642 will be found at:
https://github.com/per1234/CI-reports/tree/arduino-ci-script/build_00642

Please sign in to comment.