chore(test): Add precommit-hook #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been sitting in a branch for months. I think there was a reason why we couldn't merge it before, but it looks ok now. |
|
Ah, now I know the reason. There are a bunch of liter errors which will take some work to fix. I added a WIP commit that takes care of many of them. We can finish it off later. |
missinglink
approved these changes
Feb 8, 2019
This was never set up, and thus we have not been linting code in this repository. Fixes #311
orangejulius
force-pushed
the
add-precommit-hook
branch
from
80bfd06
to
9f2c145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was never set up, and thus we have not been linting code in this repository.
Fixes #311