Fix types, support ltc address parsing (gh-112)

paulmillr · Sep 18, 2024 · ea27eab · ea27eab
1 parent f1acec6
commit ea27eab
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/src/payment.ts b/src/payment.ts
@@ -719,14 +719,14 @@ export function Address(network = NETWORK) {
     decode(address: string): P.UnwrapCoder<OutScriptType> {
       if (address.length < 14 || address.length > 74) throw new Error('Invalid address length');
       // Bech32
-      if (network.bech32 && address.toLowerCase().startsWith(network.bech32)) {
+      if (network.bech32 && address.toLowerCase().startsWith(`${network.bech32}1`)) {
         let res;
         try {
-          res = bech32.decode(address);
+          res = bech32.decode(address as `${string}1${string}`);
           if (res.words[0] !== 0) throw new Error(`bech32: wrong version=${res.words[0]}`);
         } catch (_) {
           // Starting from version 1 it is decoded as bech32m
-          res = bech32m.decode(address);
+          res = bech32m.decode(address as `${string}1${string}`);
           if (res.words[0] === 0) throw new Error(`bech32m: wrong version=${res.words[0]}`);
         }
         if (res.prefix !== network.bech32) throw new Error(`wrong bech32 prefix=${res.prefix}`);

diff --git a/test/basic.test.js b/test/basic.test.js
@@ -44,6 +44,19 @@ should('BTC: P2PKH addresses', () => {
   deepStrictEqual(btc.p2pkh(pub).address, ADDR_1);
 });
 
+should('LTC address parsing (GH-112)', () => {
+  const ltc = {
+    bech32: 'ltc',
+    pubKeyHash: 0x30,
+    scriptHash: 0x32,
+    wif: 0xb0,
+  };
+  deepStrictEqual(btc.Address(ltc).decode('LTCHodBXqzzfDvkL1kA3dHRVsx4SCL3Y13'), {
+    hash: hex.decode('57707ca1471cab4b8cbd32a0e92f538a661e4c53'),
+    type: 'pkh',
+  });
+});
+
 // Same as above
 const TX_TEST_OUTPUTS = [
   ['1cMh228HTCiwS8ZsaakH8A8wze1JR5ZsP', 10n],