feature: request and parse HNR-ATT messages to get the attitude solution (pitch/roll/heading) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion (pitch/roll/heading)
Also read initStatus fields of esf_status
eberseth
reviewed
Jun 7, 2023
| @@ -449,6 +460,11 @@ int ubloxGPS::setOn(lib_config_t &config) | |||
| return SYSTEM_ERROR_NONE; | |||
| } | |||
|
|
|||
| void ubloxGPS::getAttitude(ubx_attitude_t *o) | |||
| { | |||
| memcpy(o, &this->attitude, sizeof(ubx_attitude_t)); | |||
There was a problem hiding this comment.
Two requests:
- Check
ois nonzero first. - Use
sizeof(*o)so that if the type ofochanges, the statement is still valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to get Pitch/Roll/Heading calculated by the GPS in my trackerone application. Here is a small patch to parse the HNR-ATT message from the ublox module.
Let me know what you think!