Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing DYNALIB_FNs for os_thread_{wait,notify} #2357

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

metcalf
Copy link

@metcalf metcalf commented Sep 16, 2021

Problem

/Users/andrew/code/supply_ventilation//src/DisplayTask.cpp:51: undefined reference to `os_thread_notify'
/Users/andrew/.particle/toolchains/gcc-arm/10.2.1/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: ../../../build/target/user/platform-6-m/supply_ventilation//libuser.a(DisplayTask.o): in function `DisplayTask::_taskFun()':
/Users/andrew/code/supply_ventilation//src/DisplayTask.cpp:59: undefined reference to `os_thread_wait'
collect2: error: ld returned 1 exit status

Solution

Added missing DYNALIB_FN entries for os_thread_{wait,notify}

Steps to Test

I assume existing compilation/tests would break if I

Example App

N/A

References

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@metcalf
Copy link
Author

metcalf commented Sep 16, 2021

Hmm, maybe this isn't an API that's intended to be exposed directly given the existence of the Thread class? Should Thread support these methods?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants