Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant XCMs from dry run's forwarded xcms #5913

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

franciscoaguirre
Copy link
Contributor

@franciscoaguirre franciscoaguirre commented Oct 3, 2024

Description

This PR addresses #5878.

After dry running an xcm on asset hub, we had redundant xcms showing up in the forwarded_xcms field of the dry run effects returned.
These were caused by two things:

  • The UpwardMessageSender router always added an element even if there were no messages.
  • The two routers on asset hub westend related to bridging (to rococo and sepolia) getting the message from their queues when their queues is actually the same xcmp queue that was already contemplated.

In order to fix this, we check for no messages in UMP and clear the implementation of InspectMessageQueues for these bridging routers.
Keep in mind that the bridged message is still sent, as normal via the xcmp-queue to Bridge Hub.
To keep on dry-running the journey of the message, the next hop to dry-run is Bridge Hub.
That'll be tackled in a different PR.

TODO

  • Functionality
  • Test

@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Oct 3, 2024
@franciscoaguirre franciscoaguirre requested a review from a team as a code owner October 3, 2024 11:03
@franciscoaguirre franciscoaguirre changed the title Remove redundant XCMs from dry ran forwarded xcms Remove redundant XCMs from dry run's forwarded xcms Oct 3, 2024
@paritytech-review-bot paritytech-review-bot bot requested review from a team October 3, 2024 11:04
@acatangiu acatangiu added the A4-needs-backport Pull request must be backported to all maintained releases. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A4-needs-backport Pull request must be backported to all maintained releases. T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants