Remove redundant XCMs from dry run's forwarded xcms #5913
+29
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #5878.
After dry running an xcm on asset hub, we had redundant xcms showing up in the
forwarded_xcms
field of the dry run effects returned.These were caused by two things:
UpwardMessageSender
router always added an element even if there were no messages.In order to fix this, we check for no messages in UMP and clear the implementation of
InspectMessageQueues
for these bridging routers.Keep in mind that the bridged message is still sent, as normal via the xcmp-queue to Bridge Hub.
To keep on dry-running the journey of the message, the next hop to dry-run is Bridge Hub.
That'll be tackled in a different PR.
TODO