Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH make event approval more robust to concurrent approval #593

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tomMoral
Copy link
Collaborator

@tomMoral tomMoral commented Mar 4, 2024

Concurrent approval leads to server errors.
This avoids the error if another process already created the sandbox submission.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.48%. Comparing base (97fbb52) to head (f4823ce).

Files Patch % Lines
ramp-database/ramp_database/tools/team.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
- Coverage   93.49%   93.48%   -0.02%     
==========================================
  Files         103      103              
  Lines        9015     9019       +4     
==========================================
+ Hits         8429     8431       +2     
- Misses        586      588       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants