feat: support shell scripts with no extension, fix perl shebang regex #4076
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnyeanderson
force-pushed
the
bash-shebang
branch
from
aa7bdff
to
fd6b906
Compare
|
Not sure if I added the CHANGELOG entry here since I'm unsure what the versioning scheme will be. Please correct me if I'm wrong. |
tnyeanderson
requested review from
nvuillam,
echoix,
bdovaz and
Kurt-von-Laven
as code owners
echoix
reviewed
Oct 1, 2024
| @@ -7,10 +7,17 @@ descriptor_flavors: | |||
| - c_cpp | |||
| - formatters | |||
| file_extensions: | |||
| - "" | |||
There was a problem hiding this comment.
What is the impact of this in projects?
There was a problem hiding this comment.
If the file without an extension does not include a matching shebang, my understanding is that there will be no impact
There was a problem hiding this comment.
However, this is needed in order for the conditional logic to even reach the point where it checks for matches in file_contains_regex. reference
tnyeanderson
force-pushed
the
bash-shebang
branch
from
fd6b906
to
5c9edc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance