feat(container): updated user widget and support dynamic updates #13412
+134
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oalkabouss
requested review from
sidlynx,
seven-amid,
tibs245,
MaximeBajeux and
sachinrameshn
github-actions
bot
added
universe-bare-metal-cloud
container
common
feature
Comment on lines
73
to
74
| {user.legalform === LEGAL_FORMS.INDIVIDUAL ? | ||
| `${user.firstname} ${user.name}`: user.organisation } |
There was a problem hiding this comment.
From the ticket I would have implemented this way:
Suggested change
| {user.legalform === LEGAL_FORMS.INDIVIDUAL ? | |
| `${user.firstname} ${user.name}`: user.organisation } | |
| {user.legalform === LEGAL_FORMS.CORPORATION? | |
| user.organisation : `${user.firstname} ${user.name}` } |
Comment on lines
107
to
108
| >{user.legalform === LEGAL_FORMS.INDIVIDUAL ? | ||
| `${user.firstname} ${user.name}` : user.organisation}</span> |
There was a problem hiding this comment.
Same as #13412 (comment)
| import { LANGUAGES } from '@ovh-ux/manager-config'; | ||
| import { getShellClient } from '../../../../shell'; |
There was a problem hiding this comment.
Can you try and inject the shell client (shellClient) directly in the constructor (you should then be able to use it this way: shellClient.getShellClient())
It should be exposed in packages/manager/apps/dedicated/client/app/app.module.js line 236:
.constant('shellClient', shellClient)
ref:MANAGER-14829 Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
oalkabouss
force-pushed
the
feat/MANAGER-14829
branch
from
c2ebfb7
to
ae4ae52
Compare
JacquesLarique
approved these changes
Oct 3, 2024
|
MaximeBajeux
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref:MANAGER-14829
masterOnly FR translations have been updatedBreaking change is mentioned in relevant commitsDescription
Related