Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pic-public-ip): Review the datagrid of Floating IP tab #13407

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

feat(pic-public-ip): Review the datagrid of Floating IP tab #13407

wants to merge 3 commits into from

Conversation

Tsiorifamonjena
Copy link
Contributor

@Tsiorifamonjena Tsiorifamonjena commented Oct 2, 2024 •
edited
Loading

Question Answer
Branch? develop
Bug fix? no
New feature? no
Breaking change? no
Tickets Fix #TAPC-757
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

  • Add new column named: Entity type
  • Set a hyperlink on the Entity ID to redirect user to the corresponding service

Related

@Tsiorifamonjena Tsiorifamonjena requested review from a team as code owners October 2, 2024 14:33
@Tsiorifamonjena Tsiorifamonjena marked this pull request as draft October 2, 2024 14:35
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.4% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-angularjs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Tsiorifamonjena