Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(savings-plan): display banner for Prod Day #13405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(savings-plan): display banner for Prod Day #13405

wants to merge 1 commit into from
+40 −35

Conversation

lionel95200x
Copy link
Contributor

@lionel95200x lionel95200x commented Oct 2, 2024 •
edited
Loading

This reverts commit c6a73c1.

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #TAPC-1866
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

To prepare the production of savings plan we display the banner in rancher and in instance page

Related

@lionel95200x lionel95200x requested review from a team as code owners October 2, 2024 14:03
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

SimonChaumet
SimonChaumet approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@SimonChaumet SimonChaumet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it should be feature flipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonChaumet SimonChaumet SimonChaumet approved these changes

@frenautvh frenautvh frenautvh approved these changes

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-angularjs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature New feature universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lionel95200x @SimonChaumet @frenautvh