Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-common): add products region selector #13391

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

feat(pci-common): add products region selector #13391

wants to merge 1 commit into from
+615 −328

Conversation

SimonChaumet
Copy link
Contributor

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? yes
Tickets
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Create a region selector compatible with products availability

Related

@SimonChaumet
feat(pci-common): add products region selector
868b671 
ref: TAPC-1358

Signed-off-by: Simon Chaumet <[email protected]>
@SimonChaumet SimonChaumet requested review from a team as code owners October 2, 2024 07:58
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SimonChaumet SimonChaumet added the blocked Don't merge yet label Oct 2, 2024
@SimonChaumet SimonChaumet marked this pull request as draft October 2, 2024 08:00
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn is a code owner automatically assigned from ovh/team-manager-dev-angularjs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blocked Don't merge yet feature New feature has conflicts Has conflicts to resolve before merging translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SimonChaumet