Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inscribing with delegate shouldn't inscribe file contents #3035

Closed
gmart7t2 opened this issue Jan 18, 2024 · 3 comments · May be fixed by #3027
Closed

Inscribing with delegate shouldn't inscribe file contents #3035

gmart7t2 opened this issue Jan 18, 2024 · 3 comments · May be fixed by #3027

Comments

@gmart7t2
Copy link
Contributor

When I use --delegate to inscribe, it complains that I still need to provide --batch or --file.

If I provide --file, the file content is included in the reveal tx as well as the delegation tag. This makes the inscription bigger than if I hadn't used delegation.

Delegation should probably skip inscribing the file content. Or better, don't require the user to specify a file when delegating the file content

@lifofifoX
Copy link
Collaborator

@gmart7t2 #3027 WIP

@bruffstar
Copy link

+1

@casey casey linked a pull request Feb 12, 2024 that will close this issue
2 tasks
@casey
Copy link
Collaborator

casey commented Apr 15, 2024

This has been implemented.

@casey casey closed this as completed Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants