Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filesystem metrics and Histogram bug fix #1594

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Filesystem metrics and Histogram bug fix #1594

wants to merge 3 commits into from

Conversation

ronnno
Copy link
Contributor

@ronnno ronnno commented Jul 13, 2020 •
edited
Loading

  • fixed formatting of results for non time values histograms
  • added metrics to filesystem reading and writing (block sizes, read/write rates)
  • added UpdateMax to gauge metric to track maximal values

@ronnno ronnno changed the title fixed histograms and added filesystem metrics Filesystem metrics and Histogram bug fix Jul 13, 2020
@ronnno ronnno mentioned this pull request Jul 13, 2020
Closed
noambergIL
noambergIL suggested changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@noambergIL noambergIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to find out what this new package is and if we can not have it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noambergIL noambergIL noambergIL requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronnno @noambergIL