Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GR-45874] Update GitHub Issue Template for Improved User Issue Reporting #9426

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

[GR-45874] Update GitHub Issue Template for Improved User Issue Reporting #9426

wants to merge 36 commits into from

Conversation

fernando-valdez
Copy link
Member

Summary

This PR updates the GitHub issue template to help users file new issues more effectively. The changes aim to streamline the issue reporting process, ensuring that users provide all necessary information for quicker and more accurate troubleshooting.

Changes

  • Added new sections for environment details, steps to reproduce, and expected behavior.
  • Included guidelines for providing clear and concise issue titles.
  • Added placeholders for logs and screenshots to better illustrate issues.
  • Updated formatting for improved readability and user guidance.

Benefits

  • Encourages users to provide comprehensive details, reducing back-and-forth communication.
  • Helps maintainers and contributors understand and reproduce issues faster.
  • Improves the overall efficiency of issue triage and resolution.

Checklist

  • Reviewed the new template for completeness and clarity.
  • Tested the template with sample issues to ensure usability.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 31, 2024
@vjovanov
Copy link
Member

vjovanov commented Aug 1, 2024

Please rebase it to master so there are no merge commits.

@vjovanov
Copy link
Member

vjovanov commented Aug 1, 2024

If the crash report can not be fused with build-time error, I think we are good for now. We will see how the fields work in practice and adjust.

@vjovanov vjovanov requested a review from fniephaus August 1, 2024 12:32
@vjovanov
Copy link
Member

vjovanov commented Aug 8, 2024

Please squash all commits and rebase to master. There should be no merge commits.

mur47x111 and others added 10 commits August 8, 2024 10:32
@mur47x111 @fernando-valdez
Update SyncPort info.
af5d1fc
@woess @fernando-valdez
Remove constant memory buffer assumption and simplify ByteArrayWasmMe…
ed0004e 
…mory.
@woess @fernando-valdez
Check that memory 0 size >= initial size at the start of a wasm funct…
550acfa 
…ion.

This allows hoisting bounds checks for memory accesses that are guaranteed to stay within the initial bounds.
@woess @fernando-valdez
Only perform initial memory 0 bounds check if the wasm function uses …
34d427d 
…memory 0.
@woess @fernando-valdez
Work around for nullary benchmarkTeardownEach() in photon benchmark.
5c08291
@woess @fernando-valdez
Fix TraceTransferToInterpreter in WasmFunctionNode.profileCondition.
f633393
@woess @fernando-valdez
Try to read WebAssembly.Module bytes via Buffer Interop.
9fe2f10
@mur47x111 @fernando-valdez
Avoid getHostBackend when instantiating UnimplementedGraalIntrinsics.
368f281
@fernando-valdez
update the crash report template
ad4ffc5
@jirkamarsik @fernando-valdez
Fix type error in WasiUnsupportedFunctionNode
02ba45d
jirkamarsik and others added 18 commits August 8, 2024 10:32
@jirkamarsik @fernando-valdez
Use fdRightsInheriting when checking rights of derived fds
ddee2bd
@jirkamarsik @fernando-valdez
Implement WASI's fd_renumber
a7e23e7
@jirkamarsik @fernando-valdez
Move fd_renumber logic to WasiFdRenumberNode
49f42ff
@jirkamarsik @fernando-valdez
Implement WASI's clock_res_get
2e1aee8
@jirkamarsik @fernando-valdez
Implement WASI's fd_tell, check offset in fd_seek
5f7e7e7
@jirkamarsik @fernando-valdez
Implement WASI's fd_datasync
57ea685
@jirkamarsik @fernando-valdez
Implement WASI's fd_pread and fd_pwrite
e788931
@jirkamarsik @fernando-valdez
Avoid using SeekableByteChannel#position on files opened in append mode
71ef264
@jirkamarsik @fernando-valdez
Implement WASI's fd_sync
56a054b
@jirkamarsik @fernando-valdez
Implement WASI's fd_filestat_set_size
dcb2346
@jirkamarsik @fernando-valdez
Implement WASI's fd_fdstat_set_rights
0f847c1
@jirkamarsik @fernando-valdez
Implement WASI's fd_readdir
3c7a09e
@jirkamarsik @fernando-valdez
Handle fd == to in fd_renumber(fd, to)
4c40696
@jirkamarsik @fernando-valdez
Fix rights checking in WASI's path_open
f5a3bca
@jirkamarsik @fernando-valdez
Simplify error code checks in FdUtils methods
e61ef39
@jirkamarsik @fernando-valdez
Improve naming of WASI implementation methods
4c4ba49
@cstancu @fernando-valdez
Make BootStrapMethodHandler more general.
9f8989e 
Allows it to be used by the ClassInitializerBytecodeParser used by the AutomaticUnsafeTransformationSupport.
@mur47x111 @fernando-valdez
Update SyncPort info.
0c1f7ed
@fernando-valdez fernando-valdez force-pushed the fv/GR-45874/update-issues-template branch from e94b28f to 0c1f7ed Compare August 8, 2024 16:33
@vjovanov
Copy link
Member

vjovanov commented Aug 9, 2024

There needs to be a single commit that is merged. Please assure that we don't merge 36 commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjovanov vjovanov vjovanov left review comments

@fniephaus fniephaus Awaiting requested review from fniephaus

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fernando-valdez @vjovanov @mur47x111 @woess @jirkamarsik @cstancu