Add support for provider specific keys #1082
Open
+41
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now scan both ./keys/n/namespace/ and ./keys/n/namespace/provider/. This allows users to provide both organization level keys and provider specific keys. Signed-off-by: Christian Mesh <[email protected]>
cam72cam
force-pushed
the
support_provider_specific_keys
branch
from
bd7982e
to
3664498
Compare
Signed-off-by: Christian Mesh <[email protected]>
abstractionfactory
requested changes
Oct 1, 2024
| Directory: p.KeyLocation, | ||
| Namespace: p.Provider.EffectiveNamespace(), | ||
| ProviderName: p.Provider.ProviderName, | ||
| Directory: p.KeyLocation, |
There was a problem hiding this comment.
I think this should be called "name" or "reponame" depending on what it contains. Also, this should be validated to avoid problems.
There was a problem hiding this comment.
Additionally, this will break BC because older OpenTofu and Terraform versions will simply ignore this field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now scan both ./keys/n/namespace/ and ./keys/n/namespace/provider/. This allows users to provide both organization level keys and provider specific keys.