Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#300 - Support in graph for each on providers in resources and modules: Add UT #2031

Open
wants to merge 1 commit into
base: 300_support_in_graph_for_each_on_providers_in_resources_and_modules_fix_ut
Choose a base branch
from

Conversation

Evi1Pumpkin
Copy link
Contributor

@Evi1Pumpkin Evi1Pumpkin commented Sep 30, 2024

Addind UT for #1963
Based of #2030
We still have a single failing test that we need to fix TestContext2Plan_destroyWithResourceConfiguredProvider.

Target Release

1.9.0

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.
  • I (and other contributors to this PR) have not looked at the Terraform source code while implementing this PR.

Go checklist

  • I have run golangci-lint on my change and receive no errors relevant to my code.
  • I have run existing tests to ensure my code doesn't break anything.
  • I have added tests for all relevant use cases of my code, and those tests are passing.
  • I have only exported functions, variables and structs that should be used from other packages.
  • I have added meaningful comments to all exported functions, variables, and structs.

Website/documentation checklist

  • I have locally started the website as described here and checked my changes.

@Evi1Pumpkin Evi1Pumpkin requested a review from a team as a code owner September 30, 2024 07:23
Copy link

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant