-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure ingress certificate for downstream testing #2882
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.34 |
@mgencur: once the present PR merges, I will cherry-pick it on top of release-1.34 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/unhold Verified downstream. The failure in upgrade tests is unrelated. It fails on other PRs as well. |
Will cherry-pick this manually as the upgrade tests might be fixed later on main branch. |
/retest |
@mgencur: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The cluster might have a specific ingress certificate and this needs to be set for the TLS tests to pass. Specifically,
test/servinge2e/encryption.TestExternalAccessWithEncryptionEnabled
Proposed Changes
/hold
Pending downstream verification.