Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure ingress certificate for downstream testing #2882

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Sep 20, 2024

The cluster might have a specific ingress certificate and this needs to be set for the TLS tests to pass. Specifically, test/servinge2e/encryption.TestExternalAccessWithEncryptionEnabled

Proposed Changes

/hold

Pending downstream verification.

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgencur
Copy link
Contributor Author

mgencur commented Sep 20, 2024

/cherry-pick release-1.34

@openshift-cherrypick-robot
Copy link
Contributor

@mgencur: once the present PR merges, I will cherry-pick it on top of release-1.34 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mgencur
Copy link
Contributor Author

mgencur commented Sep 23, 2024

/unhold

Verified downstream. The failure in upgrade tests is unrelated. It fails on other PRs as well.

@mgencur
Copy link
Contributor Author

mgencur commented Sep 23, 2024

Will cherry-pick this manually as the upgrade tests might be fixed later on main branch.

@mgencur
Copy link
Contributor Author

mgencur commented Sep 27, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

@mgencur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/416-test-upgrade-aws-416 4d008ae link true /test 416-test-upgrade-aws-416

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants