Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix husky, lint and format code #1286

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ca-d
Copy link
Contributor

@ca-d ca-d commented Aug 3, 2023

This fixes the husky installation to run pre-commit and commit-msg hooks again. This has not been working for a long time. Committing this also required fixing all linter errors, such that our code now actually lints again, and allowed me to finally run the formatter for the first time in ages, meaning we have linted and nicely formatted code again! 🎉

Fixes husky using https://github.com/typicode/husky-4-to-8 and makes all
necessary changes to make the linter happy. Finally, we can have linted
and formatted code again!
conforms all code to our prettier specification using npm run format
@ca-d ca-d marked this pull request as draft August 3, 2023 15:46
@ca-d
Copy link
Contributor Author

ca-d commented Aug 3, 2023

Converted this to draft until #1285 is merged, since this sits on top of that.

@samirromdhani
Copy link

samirromdhani commented Nov 23, 2023

Hi,
I started doing as such fixes last month in my fork, here is the commit (still wip). I recommand using realworld project as it comes with many well-specified configuration.

@ca-d
Copy link
Contributor Author

ca-d commented Nov 25, 2023

Hi, I started doing as such fixes last month in my fork

Thanks for considering this issue! I'm not sure I understand quite what you mean. Does your commit actually fix the husky pre-commit hook package? That is the topic of this pull request.

Your commit looks to me like it just includes a different eslint and prettier configuration, without actually fixing husky. If I'm not mistaken about that, be advised that this project already has a linter and formatter configuration, which follows the open-wc recommendation that this project was generated with.

@trusz
Copy link
Member

trusz commented Jul 18, 2024

This PR has a lot of conflicts but I'd like to keep it around because we can cherry-pick the configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants