-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changing open_cfradial1_datatree engine from 'netcdf4' to 'h5netcdf' #195
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
=======================================
Coverage 91.98% 91.99%
=======================================
Files 23 23
Lines 4531 4532 +1
=======================================
+ Hits 4168 4169 +1
Misses 363 363
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@aladinor I agree, this should be fixed. Could you please add |
Sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aladinor Thanks, I think this is good to go. Please add a new Development version
heading to history.md and list the your issue and your PR over there.
@@ -327,22 +327,26 @@ def open_cfradial1_datatree(filename_or_obj, **kwargs): | |||
Import optional mandatory data and metadata, defaults to ``True``. | |||
site_coords : bool | |||
Attach radar site-coordinates to Dataset, defaults to ``True``. | |||
engine: str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should work for now. No immediate need for other types, like BackendEntrypoint
. 👍
I can cut a release 👍 |
…penradar#195) * changing open_cfradial1_datatree engine from 'netcdf4' to 'h5netcdf' * passing engine as a kwarg in open_cfradial_datatree function * running pre-commit * adding new development version, issue and, and PR to history.md file * fixing some typos
history.md