adding datatree parameters #165
Conversation
… variables to the iris datatree following the FM301 standart WMO datamodel
|
@aladinor Can you rebase on latest main? Your changes are currently on top of xradar 0.2.0. |
| root.attrs.pop(k, None) | ||
|
|
||
| # handle sweep variables and dimension | ||
| root = root.rename_vars({"sweep_number": "sweep_group_name"}) |
There was a problem hiding this comment.
Should I remove them from model.py file?
There was a problem hiding this comment.
Yes, but this might show usages in other parts of xradar. If you need any help cleaning up the mess, let us know.
There was a problem hiding this comment.
I will close this PR and open a new one since I was working on an outdated folk. I can handle on my side.
|
@aladinor - I can open an issue on the Py-ART side making those fields not required. |
|
I will open a new PR since I was working on an outdated folk and I need to work on the required root variables. |
|
@aladinor You could just force-push the needed changes to your branch. No need to open a new PR. But do as you feel most comfortable with. |
|
I was worried about messing everything up. I just decided to start over. |
adding datatree parameters sweep_group_name, sweep_fixed_angle, and radar_parameters to the iris datatree following the FM301 standard WMO data model