Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Add the proper elevation angle to fixed angle #162

Merged

Conversation

mgrover1
Copy link
Collaborator

@mgrover1 mgrover1 commented Mar 14, 2024

Ensure the elevation angle is unpacked into the fixed angle variable, giving a numerical value instead of the ordered dictionary

@mgrover1 mgrover1 changed the title ENH: Add the proper elevation angle to fixed angle FIX: Add the proper elevation angle to fixed angle Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (56a9ca1) to head (f354054).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files          21       21           
  Lines        3956     3956           
=======================================
  Hits         3612     3612           
  Misses        344      344           
Flag Coverage Δ
notebooktests 80.71% <100.00%> (ø)
unittests 89.61% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kmuehlbauer kmuehlbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly! 👍

@mgrover1
Copy link
Collaborator Author

@kmuehlbauer - I am not sure why it mentions we are taking a 1.7% hit in test coverage?

@kmuehlbauer
Copy link
Collaborator

@mgrover1 No, no idea. Let's just move on here. Maybe it's just intermittent?

@kmuehlbauer
Copy link
Collaborator

Seems ok now, no?

@mgrover1
Copy link
Collaborator Author

yep! good to merge @kmuehlbauer ?

@kmuehlbauer kmuehlbauer merged commit 0145954 into openradar:main Mar 14, 2024
12 checks passed
@kmuehlbauer
Copy link
Collaborator

Thanks @mgrover1 for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Expand Sweep Fixed Mode Variables in NEXRAD Reader
2 participants