Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTWS-741: Remove OMOD-1.8 #624

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josephbate
Copy link

Description of what I changed

  1. Transfered classes and dependant classes from 1.8 to 1.9
  2. merged similliar classes that apeared in both omods
  3. Edited RestTestConstants1_9.java to include all the constants of RestTestConstants1_8.java
  4. edited all classes in the omods above 1.8 to import RestTestConstants1_9.java
  5. transfered resourse datasets from 1.8 to 1.9

Cc. @dkayiwa @ibacher @mks-d

Issue I worked on

see https://openmrs.atlassian.net/browse/RESTWS-741

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@ibacher ibacher changed the title RESTWS-741: Succefully Removed omod-1.8 RESTWS-741: Remove omod-1.8 Sep 11, 2024
@ibacher ibacher changed the title RESTWS-741: Remove omod-1.8 RESTWS-741: Remove OMOD-1.8 Sep 11, 2024
@josephbate
Copy link
Author

@ibacher is there any more requirements on this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant