RESTWS-844: Expire user sessions authenticated with old password. #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @petmongrels you can first fix the conflicting files for this |
mks-d
changed the title
mks-d
changed the title
mks-d
changed the title
mks-d
requested changes
Jul 28, 2021
There was a problem hiding this comment.
@petmongrels thanks so much for this. I skimmed through it quickly and it all makes sense at first sight. However as @HerbertYiga pointed out, this is coming with merge conflicts, I suggest that you clear them out before @dkayiwa can go into a deeper review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://issues.openmrs.org/browse/RESTWS-844
What I have done:
When a user's password is changed by the administrator or by the user oneself, then all the other active HTTP sessions are invalidated. This is to protect against scenario where the user thinks that his/her password may have been compromised.