GSoC 2019: Patient search criteria module #219
Conversation
|
did you see the conflicting files on this ticket!!! |
Reyano132
force-pushed
the
GSoC19
branch
7 times, most recently
from
4f1d29c
to
00b63a3
Compare
|
@HerbertYiga, I resolved conflict |
| @@ -255,6 +264,20 @@ | |||
| <scope>provided</scope> | |||
| </dependency> | |||
|
|
|||
| <!-- Patient search criteria module --> | |||
| <dependency> | |||
| <groupId>com.github.Reyano132.openmrs-module-patientsearchcriteria</groupId> | |||
There was a problem hiding this comment.
please revise this groupid to match our conventions https://wiki.openmrs.org/display/docs/Module+Conventions
There was a problem hiding this comment.
@kaweesi sir, here I used jitpack to host my remote repository. Jitpack added "com.github.Reyano132" prefix to the group ID. Once we officially host the patient search criteria module (https://github.com/openmrs/openmrs-module-patientsearchcriteria), I'll change the groupId value here.
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.github.Reyano132.openmrs-module-patientsearchcriteria</groupId> |
| <!-- Repository for patient search criteria --> | ||
| <repositories> | ||
| <repository> | ||
| <id>jitpack.io</id> |
There was a problem hiding this comment.
any idea why u wanna publish these on jitpack?
There was a problem hiding this comment.
@kaweesi sir, I added this repository in PR so you can use the patient search criteria module(which is not merge yet). Once you merge patient search criteria module PR(openmrs/openmrs-module-patientsearchcriteria#1) and create its remote repository, I will replace this jitpack with that repository. Another thing is that the PR of patient search criteria also consists of a jitpack repository of openmrs-core(openmrs/openmrs-core#2980).
Overall, there are dependencies between the PRs as I explained in the talk.
please 1st merge openmrs core PR(openmrs/openmrs-core#2980).
Then merge patient search criteria module PR(openmrs/openmrs-module-patientsearchcriteria#1) and create a remote repository of that module and at last, after creating a repository of patient search criteria module I just need to replace jitpack repository with patient search criteria repository
|
There is this error that occurs when you navigate to Find Patient Record
|
|
@Irenyak1 ma'am, I'm not getting such error. Have you tried this on openmrs referenceapplication-standalone-2.9.0? because I just tried this one more time today and it works fine. |
|
@rushichaudhari, can you please try on the latest snapshot reference
application version, we are here at a hackathon #OMRS19 and wanted to
finalise on this! do you think you can give feedback within 1 hour from now!
…On Tue, Dec 3, 2019 at 7:17 AM RushiChaudhari ***@***.***> wrote:
@Irenyak1 <https://github.com/Irenyak1> ma'am, I'm not getting such
error. Have you tried this on openmrs
referenceapplication-standalone-2.9.0? because I just tried this one more
time today and it works fine.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#219?email_source=notifications&email_token=ADZGJ4QE3G52FRKNP6GWC2TQWXTWRA5CNFSM4IO5YVRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFYDSVI#issuecomment-561002837>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZGJ4QNHRP626DLPRH3EBDQWXTWRANCNFSM4IO5YVRA>
.
--
*Kaweesi Joseph*
*Jembi Health Systems NPC* *| **Uganda*
*Mobile: **+256791763663** | Office: **Senior Software Developer** | Skype:*
*kaweesi.joseph*
*E-mail: [email protected] <[email protected]>*
*This e-mail contains proprietary and confidential information some or all
of which may be legally privileged. It is for the intended recipient only.
If an addressing or transmission error has misdirected this e-mail, please
notify the author by replying to this e-mail and then deleting same. If you
are not the intended recipient you must not use, disclose, distribute,
copy, print or rely on this e-mail. Jembi Health Systems NPO, its
subsidiaries and associated companies is not liable for the security of
information sent by e-mail and accepts no liability of whatsoever nature
for any loss, damage or expense resulting, directly or indirectly, from the
access of this e-mail or any attachments hereto.*
|
|
@Reyano132 I have tried it with Reference Application 2.10 SNAPSHOT. Could do like @kaweesi said and we see what comes out? |
|
@Reyano132 you may use this https://qa-refapp.openmrs.org/openmrs/login.htm. Do you know how to build using the SDK? |
Reyano132
force-pushed
the
GSoC19
branch
4 times, most recently
from
01dad2d
to
8b8d822
Compare
|
Hey @Irenyak1 , I solved the problem of repetition of the result by calling reset function from updateSearchResult function (line 514). Problem related to the gender search, can you please see the rest response, maybe you are getting an error like "org.openmrs.Person is not an indexed type". This because openmrs core does not support indexing for Person class yet. |
|
please go ahead and test well enough including confirming that applying more than one filter doesn't break the widget/results. You could also go ahead and do some styling on the new 2 element to kind of make them look more beautiful, perhaps from a vertical to a horizontal orientation |
|
Okay @kaweesi sir, I'll work on UI, but can you please help me with solving this Travis CI build problem? |
|
Hello @Reyano132 there's an issue that is still persisting, and that is the the replication of patient names when you do a search. When you time in a name of a patient and is filtered, if you remove that name, the same is duplicated as you remove the different characters. Please try to reproduce that error and look into it. Look at this, Jamie Jones Jake is replicated and the gender filter has female but even the male patients are returned |
|
Okay @Irenyak1, means whenever you are trying to apply a filter on the search result you are getting duplications in the result, Is it? |
|
Yes that's it @Reyano132 . Have you tried to reproduce the error? |
|
Yes, @Irenyak1 ma'am, I tried to reproduce that error but whenever I apply gender filter it works fine. |
|
@Reyano132 try selecting the gender then after type in a patient's name know exists. When the patient is returned, try removing the patients name one letter at a time, you may see the error. The names will be duplicated. |
|
@Irenyak1 and @kaweesi sir, can we first focus on merging OpenMRS core PR(openmrs/openmrs-core#2980). It will assure that we are using the same core and also we can use other filters also. |
|
@kaweesi could you attend to the PR from @Reyano132 so we see if the bugs are fixed? |
|
from a glance, i see a lot of feedback here unresolved. |
|
@Reyano132 could you attend to @kaweesi 's comments |
new UI of find patient widget, which supports the new patient search criteria.
GSoC 2019 Project:https://wiki.openmrs.org/display/projects/Patient+Search+Criteria