Add Lincense Headers #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmale
requested changes
Apr 2, 2024
There was a problem hiding this comment.
Two comments:
- Can you properly configure the maven-release-plugin to auto generate the headers? (This is properly configured in modules like the fhir2)
- Did you setup a Bamboo release plan for the module?
Comment on lines
+200
to
+209
| <repository> | ||
| <id>openmrs-repo-modules</id> | ||
| <name>Modules</name> | ||
| <url>http://mavenrepo.openmrs.org/nexus/content/repositories/modules/</url> | ||
| </repository> | ||
| <snapshotRepository> | ||
| <id>openmrs-repo-snapshots</id> | ||
| <name>OpenMRS Snapshots</name> | ||
| <url>http://mavenrepo.openmrs.org/nexus/content/repositories/snapshots</url> | ||
| </snapshotRepository> |
There was a problem hiding this comment.
In as much as these redirect to the same place, I would simply:
<repository>
<id>openmrs-repo-modules</id>
<name>OpenMRS Nexus Modules</name>
<url>https://mavenrepo.openmrs.org/modules</url>
</repository>
<snapshotRepository>
<id>openmrs-repo-snapshots</id>
<name>OpenMRS Nexus Snapshots</name>
<url>https://mavenrepo.openmrs.org/snapshots</url>
</snapshotRepository>
Comment on lines
-1
to
-7
| This Source Code Form is subject to the terms of the Mozilla Public License, | ||
| v. 2.0. If a copy of the MPL was not distributed with this file, You can | ||
| obtain one at http://mozilla.org/MPL/2.0/. OpenMRS is also distributed under | ||
| the terms of the Healthcare Disclaimer located at http://openmrs.org/license. | ||
|
|
||
| Copyright (C) OpenMRS Inc. OpenMRS is a registered trademark and the OpenMRS | ||
| graphic logo is a trademark of OpenMRS Inc. |
There was a problem hiding this comment.
Why are you deleting this file? Isn't this required by the license plugin here?
There was a problem hiding this comment.
Thanks for the review. Let me address your review. i will likely to finish the bamboo release pipeline this afternoon.
There was a problem hiding this comment.
Bundling CR in distro Pr here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR https://openmrs.atlassian.net/browse/HIE-7 Add Lincense Headers and few maven configuration. This is a minor fix. cc @samuelmale