Fixup #1983: Please rpmlint and add missing dependencies #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building the newly added packages may fail because of rpmlint errors. The most important ones are devel files in non-devel packages, which is caused by OpenHPC not having devel packages, library-without-ldconfig-postin and library-without-ldconfig-postun, which we do not want to run as these packages are loaded via modules. Therefore, just ignore these errors. Signed-off-by: Jan André Reuter <[email protected]>
Building OPARI2 on RHEL failed with an incorrect shebang in pomp2-parse-init-regions.awk. This occured because of missing build dependencies, causing OPARI2s configure to not find awk. Added missing dependencies to fix this issue and also added them to the other packages to present possible errors. Signed-off-by: Jan André Reuter <[email protected]>
Thyre
force-pushed
the
fix-scorep-dependency-build-issues
branch
from
fa172d9
to
f56934a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1983 after merging, there are a few issues while building the packages:
To fix this, I've added the missing dependencies not only to OPARI2, but also the other packages. This is just to make sure that nothing else breaks we haven't noticed yet. The added packages are used in the configure step.
rpmlinthad some errors, see scorep: Split components in preparation for Score-P & Scalasca update #1983 (comment)To fix this, I added the failing parts to the rpmlintrc of each package, as done with other OpenHPC packages.