Updated nuget packages and made it compile under VS2017. Fixed issue … #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when pressing back button [GoBack()] but stack is empty
|
thank you for your contribution! I do have a few remarks, if you could tackle these, I'd be happy to merge your request and push out a new version of the app.
thanks again and I'm looking forward to merge these changes in! |
|
Hi,
I’ll update and send new changes.
…________________________________
From: NicoVermeir <[email protected]>
Sent: Monday, March 5, 2018 8:52:58 AM
To: openhab/openhab.windows
Cc: Digital Nut; Author
Subject: Re: [openhab/openhab.windows] Updated nuget packages and made it compile under VS2017. Fixed issue … (#120)
thank you for your contribution!
I do have a few remarks, if you could tackle these, I'd be happy to merge your request and push out a new version of the app.
* MVVM Light got upgraded to 5.4.1 PCL version, I'd prefer it to be the .NET Standard version (https://www.nuget.org/packages/MvvmLightLibsStd10/)
* The Stylecop Analyzers are a pre-release package. I'm not a big fan of putting pre-release packages into production (even if its only a tool that is used during development). Is there a specific reason that this package was upgraded to a pre-release version?
* According to the Contribution guidelines<https://github.com/openhab/openhab.windows/blob/master/CONTRIBUTING.md> the pull request should come from a feature branch and be pulled into the dev branch
thanks again and I'm looking forward to merge these changes in!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#120 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AUYVfCv7RQVNfQ6uZIbYnK0-Q9pcWaXjks5tbW1qgaJpZM4SbtIu>.
|
|
Updated code with changes requested by NicoVermeir. (will change to feature branch for future changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when pressing back button [GoBack()] when stack is empty