feat: select questions randomly by batch of same insight #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of asking to the api for a mixt between "brand", "weight", "label" and "category" questions, the application ask for a batch of 5 questions on the same subject. The subject is chosen randomly according to the user choices |
|
@raphael0202 has just merged the same thing I think |
raphael0202
reviewed
Dec 26, 2019
| @@ -58,6 +61,7 @@ const Questions = () => { | |||
| ...(country === 'en:world' ? {} : { country }), | |||
| ...(brands ? { brands } : {}), | |||
| ...(valueTag ? { value_tag: valueTag } : {}), | |||
| ...(selectedInsights.length < Object.keys(insightTypes).length ? { insight_types: getRandomElement(selectedInsights) } : {} ), | |||
There was a problem hiding this comment.
@alexfauquette Does this mean we don't get a batches if we select all insight types?
There was a problem hiding this comment.
@raphael0202 No, it means that if you select all the insight types, you will no specify an insights type. Then you get a batch of questions with various insights
teolemon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.