Replace migrate hooks with longer timeouts and retries

This makes it possible to use this chart with fluxcd Signed-off-by: Tamal Saha <[email protected]>
openfga · Jun 11, 2024 · dd4a068 · dd4a068
1 parent eed5562
commit dd4a068
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/charts/openfga/Chart.yaml b/charts/openfga/Chart.yaml
@@ -3,7 +3,7 @@ name: openfga
 description: A Kubernetes Helm chart for the OpenFGA project.
 
 type: application
-version: 0.2.6
+version: 0.2.7
 appVersion: "v1.5.4"
 
 home: "https://openfga.github.io/helm-charts"

diff --git a/charts/openfga/templates/job.yaml b/charts/openfga/templates/job.yaml
@@ -79,5 +79,5 @@ spec:
       tolerations:
         {{- toYaml . | nindent 8 }}
       {{- end }}
-  backoffLimit: 1
+  backoffLimit: 3
 {{- end }}
diff --git a/charts/openfga/values.yaml b/charts/openfga/values.yaml
@@ -320,9 +320,11 @@ affinity: {}
 sidecars: []
 migrate:
   sidecars: []
-  annotations:
-    helm.sh/hook: "post-install, post-upgrade, post-rollback, post-delete"
-    helm.sh/hook-weight: "-5"
-    helm.sh/hook-delete-policy: "before-hook-creation"
+  # https://github.com/fluxcd/flux2/discussions/1085#discussioncomment-473271
+  # https://github.com/helm/helm/issues/9027#issuecomment-1908032461
+  annotations: {}
+    # helm.sh/hook: "post-install, post-upgrade, post-rollback, post-delete"
+    # helm.sh/hook-weight: "-5"
+    # helm.sh/hook-delete-policy: "before-hook-creation"
   labels: {}
-  timeout:
+  timeout: 10m