Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCaml 5.2.0 to the build matrix and update the vendored dependencies to fix compilation with OCaml 5.3 #6211

Closed
wants to merge 2 commits into from

Conversation

kit-ty-kate
Copy link
Member

All the vendored dependencies were updated except re while ocaml/ocaml-re#411 is being delt with.

This PR is a split from #6192 while i'm trying to figure out why the Github Action scripts do not like OCaml 5.3.0~alpha1

"5.0.0"; "5.1.1"; "5.2.0";

(* The last elements of the list after 4.14 will be used as default versions *)
"4.14.1";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"4.14.1";
"4.14.2";

@@ -65,7 +69,7 @@ let end_workflow ~oc:_ ~workflow:_ = ()
let ocamls =
List.map (fun v -> Scanf.sscanf v "%u.%u.%u" (fun major minor _ -> ((major, minor), v))) ocamls

let latest_ocaml = List.fold_left (fun _ (v, _) -> v) (0, 0) ocamls
let latest_ocaml = (4, 14)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable should be renamed to reflect its new usage

@kit-ty-kate
Copy link
Member Author

Merged into #6216

@kit-ty-kate kit-ty-kate closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants