opam switch create: better handling of already present local switch #6163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
reviewed
Sep 3, 2024
Comment on lines
+302
to
+311
| if not (OpamFilename.dir_is_empty comp_dir) then | ||
| OpamConsole.error_and_exit `Bad_arguments | ||
| "Directory %S already exists, please choose a different name" | ||
| (OpamFilename.Dir.to_string comp_dir) | ||
| else | ||
| if not (OpamConsole.confirm | ||
| "Directory %S exitst and is empty, remove it?") then | ||
| OpamConsole.error_and_exit `Aborted "Remove %S directory and recreate switch" | ||
| else | ||
| let gt, st = |
There was a problem hiding this comment.
Suggested change
| if not (OpamFilename.dir_is_empty comp_dir) then | |
| OpamConsole.error_and_exit `Bad_arguments | |
| "Directory %S already exists, please choose a different name" | |
| (OpamFilename.Dir.to_string comp_dir) | |
| else | |
| if not (OpamConsole.confirm | |
| "Directory %S exitst and is empty, remove it?") then | |
| OpamConsole.error_and_exit `Aborted "Remove %S directory and recreate switch" | |
| else | |
| let gt, st = | |
| if not (OpamFilename.dir_is_empty comp_dir) then | |
| OpamConsole.error_and_exit `Bad_arguments | |
| "Directory %S already exists, please choose a different name" | |
| (OpamFilename.Dir.to_string comp_dir) | |
| else if not (OpamConsole.confirm | |
| "Directory %S exists and is empty, remove it?") then | |
| OpamConsole.error_and_exit `Aborted "Remove %S directory and recreate switch" | |
| else | |
| let gt, st = |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.